Bug 113720

Summary: AX: Need to get line thickness from fraction on web
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, dbarton, ddkilzer, dmazzoni, jdiggs, thorton, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

chris fleizach
Reported 2013-04-01 13:52:34 PDT
For a binomial coefficient, the recommended way of encoding in MathML is to use a fraction and set the line thickness to 0, according to W3. http://www.w3.org/TR/REC-MathML/chap3_3.html See the example here: https://eyeasme.com/Joe/MathML/MathML_browser_test The MathML is: <mfenced> <mfrac linethickness="0"> <mi>n</mi> <mi>k</mi> </mfrac> </mfenced>
Attachments
patch (8.03 KB, patch)
2013-04-01 14:47 PDT, chris fleizach 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
chris fleizach
Comment 1 2013-04-01 13:52:48 PDT
rdar://13547806
chris fleizach
Comment 2 2013-04-01 14:47:07 PDT
Created attachment 196025 [details] patch
chris fleizach
Comment 3 2013-04-02 00:08:03 PDT
Adding Tim to help with review
David Kilzer (:ddkilzer)
Comment 4 2013-04-02 08:47:56 PDT
Comment on attachment 196025 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=196025&action=review r=me > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2008 > +- (NSInteger)accessibilityMathLineThickness > +{ > + if (![self _prepareAccessibilityCall]) > + return 0; I don't see this check added to some of the -accessibilityMath* methods above. Is it necessary? Should all of the methods above have this check as well?
chris fleizach
Comment 5 2013-04-02 08:49:24 PDT
Comment on attachment 196025 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=196025&action=review >> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2008 >> + return 0; > > I don't see this check added to some of the -accessibilityMath* methods above. > > Is it necessary? Should all of the methods above have this check as well? Yes they should all have that check. I've been meaning to fix that. I'll upload a new patch for that today. Thanks
WebKit Review Bot
Comment 6 2013-04-02 08:57:05 PDT
Comment on attachment 196025 [details] patch Clearing flags on attachment: 196025 Committed r147439: <http://trac.webkit.org/changeset/147439>
WebKit Review Bot
Comment 7 2013-04-02 08:57:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.