Bug 115401

Summary: [CSS Grid Layout] Fix handling of 'inherit' and 'initial' for grid lines
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, andersca, buildbot, commit-queue, dino, eflews.bot, esprehn+autocc, glenn, gyuyoung.kim, hyatt, jchaffraix, kling, koivisto, kondapallykalyan, macpherson, menard, rniwa, simon.fraser, svillar, thorton
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch
none
Patch kling: review+

Ryosuke Niwa
Reported 2013-04-30 00:55:09 PDT
We should consider back porting https://chromium.googlesource.com/chromium/blink/+/5d3509453888658290265b2ca96b569862ea396b Fix handling of 'inherit' and 'initial' for grid lines 'initial' and 'inherit' are always allowed values for CSS properties. As the CSSParser handles them automatically, those 2 values were never taken care of in StyleResolver, leading to ASSERTs triggering. While touching this code, renamed the RenderStyle grid line accessors as it shouldn't ambiguous to whom they apply. BUG=234198 TESTS=fast/css-grid-layout/grid-item-column-row-get-set.html fast/css-grid-layout/grid-item-end-after-get-set.html fast/css-grid-layout/grid-item-start-before-get-set.html Review URL: https://chromiumcodereview.appspot.com/14493016
Attachments
Patch (22.96 KB, patch)
2013-11-06 04:47 PST, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (23.05 KB, patch)
2013-11-06 07:49 PST, Sergio Villar Senin 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2013-11-06 04:47:17 PST
Created attachment 216165 [details] Patch
EFL EWS Bot
Comment 2 2013-11-06 04:58:12 PST
Comment on attachment 216165 [details] Patch Attachment 216165 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/21308195
EFL EWS Bot
Comment 3 2013-11-06 05:02:52 PST
Comment on attachment 216165 [details] Patch Attachment 216165 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/21788099
Build Bot
Comment 4 2013-11-06 05:21:16 PST
Comment on attachment 216165 [details] Patch Attachment 216165 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/21858084
Build Bot
Comment 5 2013-11-06 05:55:51 PST
Comment on attachment 216165 [details] Patch Attachment 216165 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/21738083
Build Bot
Comment 6 2013-11-06 07:14:41 PST
Comment on attachment 216165 [details] Patch Attachment 216165 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/21768096
Sergio Villar Senin
Comment 7 2013-11-06 07:49:05 PST
Created attachment 216175 [details] Patch
Sergio Villar Senin
Comment 8 2013-11-07 02:44:05 PST
Committed r158838: <http://trac.webkit.org/changeset/158838>
Note You need to log in before you can comment on or make changes to this bug.