Bug 120871

Summary: MediaStream should fire ended event when all tracks are ended
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebCore Misc.Assignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, hta, jer.noble, tommyw
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121101    
Attachments:
Description Flags
Proposed patch
none
Updated patch, this time without already-landed-changes
none
Patch that causes fewer regressions, AND with a complete ChangeLog!
none
Updated patch none

Eric Carlson
Reported 2013-09-06 11:44:54 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/bebd179b65be69e46f2f434a3ec8b1e4aa85cc42 MediaStream should fire ended event when all tracks are ended
Attachments
Proposed patch (14.59 KB, patch)
2013-09-06 14:14 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Updated patch, this time without already-landed-changes (11.67 KB, patch)
2013-09-06 14:33 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch that causes fewer regressions, AND with a complete ChangeLog! (7.61 KB, patch)
2013-09-06 14:55 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Updated patch (7.20 KB, patch)
2013-09-06 16:51 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2013-09-06 14:14:57 PDT
Created attachment 210799 [details] Proposed patch
Eric Carlson
Comment 2 2013-09-06 14:33:27 PDT
Created attachment 210800 [details] Updated patch, this time without already-landed-changes
Eric Carlson
Comment 3 2013-09-06 14:55:59 PDT
Created attachment 210802 [details] Patch that causes fewer regressions, AND with a complete ChangeLog!
Eric Carlson
Comment 4 2013-09-06 16:51:20 PDT
Created attachment 210817 [details] Updated patch
Jer Noble
Comment 5 2013-09-06 17:52:31 PDT
Comment on attachment 210817 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=210817&action=review r=me, with nit: > Source/WebCore/ChangeLog:4 > + MediaStream should fire ended event when all tracks are ended > + https://bugs.webkit.org/show_bug.cgi?id=120871 This should include a line stating that this is a blink merge, and include the URL to the blink commit.
Eric Carlson
Comment 6 2013-09-07 08:34:26 PDT
Comment on attachment 210817 [details] Updated patch (In reply to comment #5) > (From update of attachment 210817 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=210817&action=review > > r=me, with nit: > > > Source/WebCore/ChangeLog:4 > > + MediaStream should fire ended event when all tracks are ended > > + https://bugs.webkit.org/show_bug.cgi?id=120871 > > This should include a line stating that this is a blink merge, and include the URL to the blink commit. Oops, good point. Done.
Eric Carlson
Comment 7 2013-09-07 08:34:52 PDT
Committed r155249: https://trac.webkit.org/r155249
Note You need to log in before you can comment on or make changes to this bug.