Bug 126343

Summary: [SOUP] Add stubs for CustomProtocol classes
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, beidson, bunhere, cdumez, commit-queue, gustavo, gyuyoung.kim, mkwst, rakuco, svillar, zan
Priority: P2 Keywords: Gtk, Soup
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 125583    
Attachments:
Description Flags
Patch
none
Updated (hopefully correctly) cmake files too
none
Rebased patch gustavo: review+

Carlos Garcia Campos
Reported 2013-12-31 08:24:56 PST
This will simplify the patch that actually implements custom protocols for soup.
Attachments
Patch (12.44 KB, patch)
2013-12-31 08:29 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated (hopefully correctly) cmake files too (14.08 KB, patch)
2013-12-31 08:46 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Rebased patch (14.10 KB, patch)
2014-01-16 00:16 PST, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-12-31 08:29:38 PST
Created attachment 220162 [details] Patch
Martin Robinson
Comment 2 2013-12-31 08:31:02 PST
Comment on attachment 220162 [details] Patch Soup bits look good to me, but do you mind also updating the CMake files?
Carlos Garcia Campos
Comment 3 2013-12-31 08:46:55 PST
Created attachment 220163 [details] Updated (hopefully correctly) cmake files too
Carlos Garcia Campos
Comment 4 2014-01-16 00:16:50 PST
Created attachment 221339 [details] Rebased patch
Gustavo Noronha (kov)
Comment 5 2014-01-16 03:24:49 PST
Comment on attachment 221339 [details] Rebased patch Looks right to me!
Carlos Garcia Campos
Comment 6 2014-01-16 23:46:41 PST
Committed r162190: <http://trac.webkit.org/changeset/162190>
Note You need to log in before you can comment on or make changes to this bug.