Bug 144785

Summary: [GTK] Fails to link libwebkit2gtkinjectedbundle.so on OSX
Product: WebKit Reporter: Philip Chimento <philip.chimento>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major CC: cgarcia, commit-queue, mcatanzaro, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: OS X 10.10   
Bug Depends on:    
Bug Blocks: 126492, 144561    
Attachments:
Description Flags
Patch none

Philip Chimento
Reported 2015-05-07 23:26:47 PDT
On GTK / OSX, the build fails with this error: Linking CXX shared module ../../lib/libwebkit2gtkinjectedbundle.so Undefined symbols for architecture x86_64: "WebKit::WebGtkExtensionManager::initialize(OpaqueWKBundle const*, void const*)", referenced from: _WKBundleInitialize in WebGtkInjectedBundleMain.cpp.o "WebKit::WebGtkExtensionManager::shared()", referenced from: _WKBundleInitialize in WebGtkInjectedBundleMain.cpp.o ld: symbol(s) not found for architecture x86_64 make[2]: *** [lib/libwebkit2gtkinjectedbundle.so] Error 1 make[1]: *** [Source/WebKit2/CMakeFiles/webkit2gtkinjectedbundle.dir/all] Error 2
Attachments
Patch (1.42 KB, patch)
2015-05-07 23:40 PDT, Philip Chimento 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philip Chimento
Comment 1 2015-05-07 23:40:40 PDT
Created attachment 252690 [details] Patch
Michael Catanzaro
Comment 2 2015-06-28 15:34:40 PDT
I wonder why this is necessary....
Philip Chimento
Comment 3 2015-07-01 22:49:06 PDT
(In reply to comment #2) > I wonder why this is necessary.... I'm not sure either. I suspect it's due to some difference in how XCode's linker handles other DSOs linked by the objects it's linking. Perhaps GNU's linker pulls them in, while XCode's linker requires them to be explicitly added to the linker command line.
WebKit Commit Bot
Comment 4 2015-11-06 01:49:40 PST
Comment on attachment 252690 [details] Patch Clearing flags on attachment: 252690 Committed r192096: <http://trac.webkit.org/changeset/192096>
WebKit Commit Bot
Comment 5 2015-11-06 01:49:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.