Bug 145440

Summary: Rename HTMLMediaSession to HTMLMediaElementSession in anticipation of Media Session API
Product: WebKit Reporter: Matt Rajca <mrajca>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 145411    
Attachments:
Description Flags
Patch
none
Patch none

Matt Rajca
Reported 2015-05-28 10:44:59 PDT
As discussed with Eric Carlson and Jer Noble, we should rename HTMLMediaSession to HTMLMediaElementSession to reserve "media session" for the Media Session API (bug 145411).
Attachments
Patch (65.66 KB, patch)
2015-05-28 12:10 PDT, Matt Rajca 		no flags
DetailsFormatted DiffDiff
Patch (66.53 KB, patch)
2015-05-28 14:51 PDT, Matt Rajca 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-05-28 10:46:13 PDT
<rdar://problem/21142951>
Matt Rajca
Comment 2 2015-05-28 12:10:30 PDT
Created attachment 253854 [details] Patch
WebKit Commit Bot
Comment 3 2015-05-28 12:13:17 PDT
Attachment 253854 [details] did not pass style-queue: ERROR: Source/WebCore/html/HTMLMediaElementSession.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/html/HTMLMediaElementSession.cpp:58: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 4 2015-05-28 12:47:32 PDT
Comment on attachment 253854 [details] Patch Generally we only want to use the HTML prefix for classes actually exposed to the DOM. So I think MediaElementSession would be better.
Matt Rajca
Comment 5 2015-05-28 12:56:49 PDT
I'll send out a new patch. I already ran this change by Eric as well.
Matt Rajca
Comment 6 2015-05-28 14:51:36 PDT
Created attachment 253866 [details] Patch
WebKit Commit Bot
Comment 7 2015-05-28 14:53:15 PDT
Attachment 253866 [details] did not pass style-queue: ERROR: Source/WebCore/html/MediaElementSession.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/html/MediaElementSession.cpp:58: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 8 2015-05-28 16:03:52 PDT
Comment on attachment 253866 [details] Patch Clearing flags on attachment: 253866 Committed r184966: <http://trac.webkit.org/changeset/184966>
WebKit Commit Bot
Comment 9 2015-05-28 16:03:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.