Bug 172645

Summary:

Make webrtc replace track tests less flaky

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, eric.carlson, jonlee, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=171895

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none

youenn fablet

Reported 2017-05-26 07:45:28 PDT

Make webrtc replace track tests less flaky

Attachments
Patch (13.17 KB, patch) 2017-05-26 07:56 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (18.93 KB, patch) 2017-09-18 13:37 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (18.88 KB, patch) 2017-09-20 10:39 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-05-26 07:56:50 PDT

Created attachment 311353 [details] Patch

Eric Carlson

Comment 2 2017-05-26 17:28:45 PDT

Comment on attachment 311353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311353&action=review > LayoutTests/webrtc/video-replace-track-to-null.html:24 > + framesEncoded = statItem.framesEncoded; Should this break? If not, what does it meant to have more than one?

youenn fablet

Comment 3 2017-05-30 08:38:03 PDT

Comment on attachment 311353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311353&action=review >> LayoutTests/webrtc/video-replace-track-to-null.html:24 >> + framesEncoded = statItem.framesEncoded; > > Should this break? If not, what does it meant to have more than one? We are in forEach, not in a for loop, I do not know whether there is a way to break here. There should only be one outbound-rtp since we have only one track. It might be good to ensure that in video-stats.html

WebKit Commit Bot

Comment 4 2017-05-30 08:39:01 PDT

Comment on attachment 311353 [details] Patch Rejecting attachment 311353 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 311353, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: le LayoutTests/TestExpectations.rej patching file LayoutTests/platform/mac-wk2/TestExpectations patching file LayoutTests/webrtc/audio-replace-track.html patching file LayoutTests/webrtc/video-replace-track-expected.txt patching file LayoutTests/webrtc/video-replace-track-to-null.html patching file LayoutTests/webrtc/video-replace-track.html Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Eric Carlson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3842443

Radar WebKit Bug Importer

Comment 5 2017-08-28 14:09:42 PDT

<rdar://problem/34118218>

youenn fablet

Comment 6 2017-09-18 13:37:12 PDT

Created attachment 321124 [details] Patch

Alex Christensen

Comment 7 2017-09-18 21:10:46 PDT

Comment on attachment 321124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321124&action=review > LayoutTests/TestExpectations:802 > -webkit.org/b/170704 webrtc/video-mute.html [ Failure ] > +webkit.org/b/170704 webrtc/video-mute.html [ Pass Failure ] Why?

youenn fablet

Comment 8 2017-09-18 22:11:52 PDT

(In reply to Alex Christensen from comment #7) > Comment on attachment 321124 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321124&action=review > > > LayoutTests/TestExpectations:802 > > -webkit.org/b/170704 webrtc/video-mute.html [ Failure ] > > +webkit.org/b/170704 webrtc/video-mute.html [ Pass Failure ] > > Why? The line should be removed. I am keeping Failure expectation until I am sure it is not flaky.

WebKit Commit Bot

Comment 9 2017-09-20 10:36:17 PDT

Comment on attachment 321124 [details] Patch Rejecting attachment 321124 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 321124, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: hing file LayoutTests/webrtc/routines.js patching file LayoutTests/webrtc/video-mute.html patching file LayoutTests/webrtc/video-replace-muted-track.html patching file LayoutTests/webrtc/video-replace-track-expected.txt patching file LayoutTests/webrtc/video-replace-track-to-null.html patching file LayoutTests/webrtc/video-replace-track.html Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Eric Carlson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/4605147

youenn fablet

Comment 10 2017-09-20 10:39:46 PDT

Created attachment 321331 [details] Patch for landing

WebKit Commit Bot

Comment 11 2017-09-20 11:10:59 PDT

Comment on attachment 321331 [details] Patch for landing Clearing flags on attachment: 321331 Committed r222273: <http://trac.webkit.org/changeset/222273>

WebKit Commit Bot

Comment 12 2017-09-20 11:11:01 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.