Bug 181172

Summary: Identify MessagePorts by a globally unique MessagePortIdentifier
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 181155    
Bug Blocks: 181178    
Attachments:
Description Flags
Patch
achristensen: review+
PFL
none
Archive of layout-test-results from ews125 for ios-simulator-wk2 none

Brady Eidson
Reported 2017-12-26 21:27:32 PST
Identify MessagePorts by a globally unique MessagePortIdentifier "Globally unique" in this context means that no matter which process a MessagePort is originally created in, its identifier is guaranteed to not conflict with a port created in any other process. See https://bugs.webkit.org/show_bug.cgi?id=181155 for the precursor to this. This is the final refactor necessary before WK2 multi-process MessagePorts.
Attachments
Patch (23.02 KB, patch)
2017-12-29 09:56 PST, Brady Eidson 		achristensen: review+
DetailsFormatted DiffDiff
PFL (22.36 KB, patch)
2018-01-02 12:54 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.35 MB, application/zip)
2018-01-02 14:09 PST, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2017-12-29 09:56:19 PST
Created attachment 330255 [details] Patch
Alex Christensen
Comment 2 2018-01-02 11:07:05 PST
Comment on attachment 330255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330255&action=review > Source/WebCore/dom/MessagePortIdentifier.h:76 > + unsigned hashes[2]; > + hashes[0] = WTF::intHash(processIdentifier.toUInt64()); > + hashes[1] = WTF::intHash(portIdentifier.toUInt64()); > + > + return StringHasher::hashMemory(hashes, sizeof(hashes)); Could this use Darin's new computeHash? See https://bugs.webkit.org/show_bug.cgi?id=180318
Brady Eidson
Comment 3 2018-01-02 12:54:30 PST
Created attachment 330329 [details] PFL
EWS Watchlist
Comment 4 2018-01-02 14:09:48 PST
Comment on attachment 330329 [details] PFL Attachment 330329 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5895383 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/update-after-navigation-fetch-event.https.html
EWS Watchlist
Comment 5 2018-01-02 14:09:49 PST
Created attachment 330332 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Brady Eidson
Comment 6 2018-01-02 14:21:35 PST
(In reply to Build Bot from comment #4) > Comment on attachment 330329 [details] > PFL > > Attachment 330329 [details] did not pass ios-sim-ews (ios-simulator-wk2): > Output: http://webkit-queues.webkit.org/results/5895383 > > New failing tests: > imported/w3c/web-platform-tests/service-workers/service-worker/update-after- > navigation-fetch-event.https.html Hmmmmm not caused by this patch.
WebKit Commit Bot
Comment 7 2018-01-02 14:42:20 PST
Comment on attachment 330329 [details] PFL Clearing flags on attachment: 330329 Committed r226336: <https://trac.webkit.org/changeset/226336>
Radar WebKit Bug Importer
Comment 8 2018-01-09 15:14:33 PST
<rdar://problem/36387284>
Note You need to log in before you can comment on or make changes to this bug.