Bug 181205

Summary: Make MessagePortChannel::takeAllMessagesFromRemote asynchronous
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181178    
Attachments:
Description Flags
Patch
none
Patch
achristensen: review+
Patch none

Brady Eidson
Reported 2018-01-01 10:16:44 PST
Make MessagePortChannel::takeAllMessagesFromRemote asynchronous
Attachments
Patch (4.28 KB, text/plain)
2018-01-01 17:54 PST, Brady Eidson 		no flags
Details
Patch (5.26 KB, patch)
2018-01-02 14:14 PST, Brady Eidson 		achristensen: review+
DetailsFormatted DiffDiff
Patch (5.44 KB, patch)
2018-01-02 15:44 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2018-01-01 17:54:42 PST
Created attachment 330303 [details] Patch This patch relies on another one currently in the review queue - Won't submit to EWS until after it lands.
Brady Eidson
Comment 2 2018-01-02 14:14:05 PST
Created attachment 330333 [details] Patch Will not mark as patch until the patch in 181172 lands
Alex Christensen
Comment 3 2018-01-02 14:47:43 PST
Comment on attachment 330333 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330333&action=review > Source/WebCore/dom/MessagePort.cpp:206 > + m_entangledChannel->takeAllMessagesFromRemote([protectedThis = makeRef(*this), this](Deque<std::unique_ptr<MessagePortChannel::EventData>>&& messages) { I like to capture this first. I don't think we've discussed this style. Pun intended. > Source/WebCore/dom/MessagePortChannel.h:70 > + virtual void takeAllMessagesFromRemote(WTF::Function<void(Deque<std::unique_ptr<EventData>>&&)>&&) = 0; We shouldn't need the WTF:: prefix since r222473. This could also be a CompletionHandler.
Brady Eidson
Comment 4 2018-01-02 15:44:21 PST
Created attachment 330346 [details] Patch
WebKit Commit Bot
Comment 5 2018-01-02 16:51:04 PST
Comment on attachment 330346 [details] Patch Clearing flags on attachment: 330346 Committed r226343: <https://trac.webkit.org/changeset/226343>
Radar WebKit Bug Importer
Comment 6 2018-01-09 09:10:25 PST
<rdar://problem/36376756>
Note You need to log in before you can comment on or make changes to this bug.