Bug 204045

Summary:

iOS: fast/events/scroll-subframe-in-rendering-update.html always fails

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, rniwa, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=203839

Attachments:

Description	Flags
Disable frame flattening	none
Fix attempt no.2	none
Patch for landing	none

Aakash Jain

Reported 2019-11-09 03:55:52 PST

The following layout test is failing consistently on iOS Simulator Debug/Release: fast/events/scroll-subframe-in-rendering-update.html Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fevents%2Fscroll-subframe-in-rendering-update.html https://results.webkit.org/?suite=layout-tests&test=fast%2Fevents%2Fscroll-subframe-in-rendering-update.html e.g.: https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Release%20WK2%20(Tests)/r252205%20(939)/results.html https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Release%20WK2%20(Tests)/r252231%20(947)/results.html https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Release%20WK2%20(Tests)/r252240%20(954)/results.html https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Release%20WK2%20(Tests)/r252262%20(960)/results.html https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Debug%20WK2%20(Tests)/r252299%20(810)/results.html https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Debug%20WK2%20(Tests)/r252205%20(788)/results.html https://ews-build.webkit.org/results/iOS-13-Simulator-WK2-Tests-EWS/r383072-4464/results.html

Attachments
Disable frame flattening (1.34 KB, patch) 2019-11-09 15:29 PST, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Fix attempt no.2 (1.55 KB, patch) 2019-11-09 23:18 PST, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Patch for landing (2.11 KB, patch) 2019-11-10 17:27 PST, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-11-09 03:56:14 PST

Diff: --- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/events/scroll-subframe-in-rendering-update-expected.txt +++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/events/scroll-subframe-in-rendering-update-actual.txt @@ -8,9 +8,10 @@ iframeAA.contentWindow.scrollTo(0, 1000); updateLayout(iframeAA) PASS logs.length is 0 After requestAnimationFrame -PASS logs.length is 3 -PASS logs.join(", ") is "A, AA, B" +FAIL logs.length should be 3. Was 0. +FAIL logs.join(", ") should be A, AA, B. Was . PASS successfullyParsed is true +Some tests failed. TEST COMPLETE

Radar WebKit Bug Importer

Comment 2 2019-11-09 03:56:20 PST

<rdar://problem/57047296>

Radar WebKit Bug Importer

Comment 3 2019-11-09 03:59:46 PST

<rdar://problem/57047315>

Aakash Jain

Comment 4 2019-11-09 04:02:01 PST

This test was added 2 days back in http://trac.webkit.org/changeset/252205/webkit and has been failing on iOS since then.

Ryosuke Niwa

Comment 5 2019-11-09 15:20:01 PST

Ugh... frame flattening is in effect here.

Ryosuke Niwa

Comment 6 2019-11-09 15:29:41 PST

Created attachment 383229 [details] Disable frame flattening

Ryosuke Niwa

Comment 7 2019-11-09 15:55:01 PST

Ugh... I need to download & install a new iOS SDK to test this out. Doing that now.

Ryosuke Niwa

Comment 8 2019-11-09 19:30:10 PST

Committed r252311: <https://trac.webkit.org/changeset/252311>

Ryosuke Niwa

Comment 9 2019-11-09 19:33:26 PST

Ugh... I can't either SSH into my machine or download the iOS SDK. Landing the fix speculatively for now. If this doesn't work, we probably need to skip the test on iOS for now until I regain access to a machine with functional iOS SDK.

Aakash Jain

Comment 10 2019-11-09 22:14:42 PST

(In reply to Ryosuke Niwa from comment #8) > Committed r252311: <https://trac.webkit.org/changeset/252311> Seems to be still failing. https://build.webkit.org/builders/Apple%20iOS%2013%20Simulator%20Release%20WK2%20%28Tests%29/builds/975

Ryosuke Niwa

Comment 11 2019-11-09 23:08:09 PST

Oh, I think we probably also need .

Ryosuke Niwa

Comment 12 2019-11-09 23:12:35 PST

Added the failing expectation in https://trac.webkit.org/r252312 for now.

Ryosuke Niwa

Comment 13 2019-11-09 23:18:11 PST

Created attachment 383237 [details] Fix attempt no.2

Ryosuke Niwa

Comment 14 2019-11-09 23:20:25 PST

It's really annoying that we need to enable random ass flags in the tests to make scrolling tests to work in iOS. We should probably flip the default so that async scrolling is enabled by default so that many of existing layout tests for scrolling behavior can be enabled on iOS, and create a separate set of tests for frame flattening.

Aakash Jain

Comment 15 2019-11-10 13:54:27 PST

(In reply to Ryosuke Niwa from comment #13) > Created attachment 383237 [details] > Fix attempt no.2 Did you want to update the TestExpectations as well? I guess EWS results for this patch wouldn't have covered this test because we pass --skip-failing-tests to run-webkit-tests in EWS.

Ryosuke Niwa

Comment 16 2019-11-10 17:26:26 PST

(In reply to Aakash Jain from comment #15) > (In reply to Ryosuke Niwa from comment #13) > > Created attachment 383237 [details] > > Fix attempt no.2 > Did you want to update the TestExpectations as well? > > I guess EWS results for this patch wouldn't have covered this test because > we pass --skip-failing-tests to run-webkit-tests in EWS. WTF!? When did we start doing that?

Ryosuke Niwa

Comment 17 2019-11-10 17:27:22 PST

Created attachment 383251 [details] Patch for landing

Ryosuke Niwa

Comment 18 2019-11-10 17:27:33 PST

Comment on attachment 383251 [details] Patch for landing Wait for EWS.

Aakash Jain

Comment 19 2019-11-10 18:52:11 PST

(In reply to Ryosuke Niwa from comment #16) > (In reply to Aakash Jain from comment #15) > > (In reply to Ryosuke Niwa from comment #13) > > > Created attachment 383237 [details] > > > Fix attempt no.2 > > Did you want to update the TestExpectations as well? > > > > I guess EWS results for this patch wouldn't have covered this test because > > we pass --skip-failing-tests to run-webkit-tests in EWS. > > WTF!? When did we start doing that? Seems like we started it in https://trac.webkit.org/changeset/106518/webkit

WebKit Commit Bot

Comment 20 2019-11-10 21:39:29 PST

Comment on attachment 383251 [details] Patch for landing Clearing flags on attachment: 383251 Committed r252317: <https://trac.webkit.org/changeset/252317>

WebKit Commit Bot

Comment 21 2019-11-10 21:39:31 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.