Bug 213869

Summary: [JSC] Intl.Collator should set usage:"search" option through ICU locale
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 213425    
Attachments:
Description Flags
Patch
none
Patch
ross.kirsling: review+
Patch for landing
none
Patch for landing none

Yusuke Suzuki
Reported 2020-07-01 19:09:03 PDT
[JSC] Intl.Collator should set usage:"search" option through ICU locale
Attachments
Patch (8.66 KB, patch)
2020-07-01 19:11 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (7.70 KB, patch)
2020-07-01 19:53 PDT, Yusuke Suzuki 		ross.kirsling: review+
DetailsFormatted DiffDiff
Patch for landing (7.66 KB, patch)
2020-07-01 20:21 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.13 KB, patch)
2020-07-01 20:49 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-07-01 19:11:32 PDT
Created attachment 403337 [details] Patch
Yusuke Suzuki
Comment 2 2020-07-01 19:23:38 PDT
Comment on attachment 403337 [details] Patch I'll add more handling for privateuse.
Yusuke Suzuki
Comment 3 2020-07-01 19:53:26 PDT
Created attachment 403339 [details] Patch
Ross Kirsling
Comment 4 2020-07-01 19:55:57 PDT
Comment on attachment 403339 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403339&action=review LGTM > JSTests/stress/intl-collator-co-extension.js:6 > +function shouldBeArray(actual, expected) { I should do this more often...I've used JSON.stringify too much in our Intl tests, haha.
Yusuke Suzuki
Comment 5 2020-07-01 20:18:04 PDT
Comment on attachment 403339 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403339&action=review > Source/JavaScriptCore/runtime/IntlCollator.cpp:249 > + dataLocaleWithExtensions = dataLocale.utf8(); I need to make it `m_locale.utf8()` since "co" option in usage:"sort" is effective.
Yusuke Suzuki
Comment 6 2020-07-01 20:21:21 PDT
Created attachment 403340 [details] Patch for landing
Yusuke Suzuki
Comment 7 2020-07-01 20:49:01 PDT
Created attachment 403341 [details] Patch for landing
Yusuke Suzuki
Comment 8 2020-07-01 22:56:19 PDT
ios and win failures are unrelated. Win failure is due to bad state of EWS (re-run of EWS is failing). ios thing is failing without this patch. https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fcanvas%2F2d.gradient.radial.cone.bottom.html
Yusuke Suzuki
Comment 9 2020-07-01 23:00:44 PDT
Committed r263833: <https://trac.webkit.org/changeset/263833>
Radar WebKit Bug Importer
Comment 10 2020-07-01 23:01:23 PDT
<rdar://problem/65019917>
Note You need to log in before you can comment on or make changes to this bug.