Bug 215096

Summary: Add constructor for AudioBufferSourceNode
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, clark_wang, darin, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://www.w3.org/TR/webaudio/#AudioBufferSourceNode
Bug Depends on:    
Bug Blocks: 212611, 215106    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2020-08-03 13:03:16 PDT
Add constructor for AudioBufferSourceNode, as per: - https://www.w3.org/TR/webaudio/#AudioBufferSourceNode
Attachments
Patch (72.53 KB, patch)
2020-08-03 14:15 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (68.69 KB, patch)
2020-08-03 15:36 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (68.71 KB, patch)
2020-08-03 16:06 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-08-03 14:15:12 PDT
Created attachment 405864 [details] Patch
Darin Adler
Comment 2 2020-08-03 14:46:40 PDT
Comment on attachment 405864 [details] Patch Seems that default values for some fields are listed in multiple places. I bet some of the places aren’t actually affecting things. Would be nice to reduce this a bit in the future. Default values that have no effect.
Chris Dumez
Comment 3 2020-08-03 15:36:16 PDT
Created attachment 405874 [details] Patch
Chris Dumez
Comment 4 2020-08-03 16:06:51 PDT
Created attachment 405882 [details] Patch
EWS
Comment 5 2020-08-03 17:32:01 PDT
Committed r265233: <https://trac.webkit.org/changeset/265233> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405882 [details].
Radar WebKit Bug Importer
Comment 6 2020-08-03 17:33:19 PDT
<rdar://problem/66500063>
Note You need to log in before you can comment on or make changes to this bug.