Bug 234523

Summary: Roll ANGLE to aabfe8747d 12-17-2021
Product: WebKit Reporter: Kyle Piddington <kpiddington>
Component: ANGLEAssignee: Kyle Piddington <kpiddington>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, dino, ews-watchlist, gyuyoung.kim, kbr, kkinnunen, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 234391    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Kyle Piddington
Reported 2021-12-20 12:46:27 PST
Roll ANGLE to aabfe8747d 12-17-2021
Attachments
Patch (1.10 MB, patch)
2021-12-20 12:47 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch (1.09 MB, patch)
2022-01-04 11:27 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.09 MB, patch)
2022-01-05 11:13 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kyle Piddington
Comment 1 2021-12-20 12:47:44 PST
Created attachment 447623 [details] Patch
EWS Watchlist
Comment 2 2021-12-20 12:51:02 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 3 2021-12-20 13:04:26 PST
Comment on attachment 447623 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447623&action=review Great to see the progress reducing the diffs from upstream. r+ from me; most carefully reviewed the Metal backend changes, and changes.diff. A couple of small questions; feel free to move ahead without re-review. > Source/ThirdParty/ANGLE/ChangeLog:8 > + * ANGLE.plist: Suggest trimming ChangeLog as before. > Source/ThirdParty/ANGLE/changes.diff:922 > + switch_data += "#if (TARGET_OS_OSX && (__MAC_OS_X_VERSION_MAX_ALLOWED >= 110000))\n" Could you double-check whether these ifdefs were properly upstreamed? Thought these diffs should have been resolved already.
Radar WebKit Bug Importer
Comment 4 2021-12-27 12:47:15 PST
<rdar://problem/86943857>
Kyle Piddington
Comment 5 2022-01-04 11:27:38 PST
Created attachment 448311 [details] Patch
Kenneth Russell
Comment 6 2022-01-04 17:55:56 PST
Comment on attachment 448311 [details] Patch Looks good to me - r+. I most carefully reviewed changes.diff and all the changes under src/libANGLE/renderer/metal.
Kyle Piddington
Comment 7 2022-01-05 11:13:18 PST
Created attachment 448411 [details] Patch for landing
EWS
Comment 8 2022-01-05 14:00:06 PST
Committed r287652 (245750@main): <https://commits.webkit.org/245750@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448411 [details].
Note You need to log in before you can comment on or make changes to this bug.