Bug 306081
| Summary: | [appearance: base] Move the pseudoElementType and pseudoBits to NonInheritedRareData | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Forms | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=305085 https://bugs.webkit.org/show_bug.cgi?id=306383 |
||
| Bug Depends on: | |||
| Bug Blocks: | 305601 | ||
Said Abou-Hallawa
Adding a pseudo element requires increasing PublicPseudoIDBits by 1. At some point an extra bit will add 4 bytes to the NonInheritedFlags. And because of the structure alignment, this will increase RenderStyle by 8 bytes. This caused perf regression on SP3 and on MotionMark; see bug 305085.
To allow adding more pseudo elements without regressing the benchmarks. the pseudoElementType and pseudoBits can be moved from ComputedStyleBase::NonInheritedFlags to NonInheritedMiscData.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/168722225>
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/57093
Said Abou-Hallawa
The approach of this bug is wrong. Moving the pseudo elements bits to the rare data causes more mismatch in the MatchedDeclarationsCache. This should be fixed by bug 306383.