Bug 57538

Summary: Web Inspector: CSS domain - make a "range" object, get rid of "properties" object for Style objects
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Suggested solution
none
[
none
[PATCH] Remove inadvertently added blank line yurys: review+

Alexander Pavlov (apavlov)
Reported 2011-03-31 04:49:30 PDT
"startOffset"/"endOffset" should reside in a separate "range" object, and the "properties" object (for the CSS style) should go away (width/height get inlined into the CSS style object).
Attachments
[PATCH] Suggested solution (10.86 KB, patch)
2011-03-31 05:44 PDT, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
[ (10.81 KB, patch)
2011-03-31 05:46 PDT, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
[PATCH] Remove inadvertently added blank line (10.81 KB, patch)
2011-03-31 05:47 PDT, Alexander Pavlov (apavlov) 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2011-03-31 05:44:14 PDT
Created attachment 87706 [details] [PATCH] Suggested solution
Alexander Pavlov (apavlov)
Comment 2 2011-03-31 05:46:20 PDT
Created attachment 87707 [details] [
Alexander Pavlov (apavlov)
Comment 3 2011-03-31 05:47:11 PDT
Created attachment 87708 [details] [PATCH] Remove inadvertently added blank line
Yury Semikhatsky
Comment 4 2011-03-31 06:57:51 PDT
Comment on attachment 87708 [details] [PATCH] Remove inadvertently added blank line View in context: https://bugs.webkit.org/attachment.cgi?id=87708&action=review > LayoutTests/inspector/styles/styles-source-offsets.html:12 > + function rangeText(range) Can you move this method into a common file for inspector CSS tests? > LayoutTests/inspector/styles/styles-source-offsets.html:33 > + InspectorTest.addResult(header + " [" + style.range.start + "-" + style.range.end + "]"); Please use rangeText instead.
WebKit Review Bot
Comment 5 2011-03-31 08:28:03 PDT
http://trac.webkit.org/changeset/82578 might have broken GTK Linux 32-bit Release
Alexander Pavlov (apavlov)
Comment 6 2011-03-31 09:00:08 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/http/tests/inspector/elements-test.js M LayoutTests/inspector/styles/get-set-stylesheet-text.html M LayoutTests/inspector/styles/styles-new-API.html M LayoutTests/inspector/styles/styles-source-offsets.html M Source/WebCore/ChangeLog M Source/WebCore/inspector/InspectorStyleSheet.cpp M Source/WebCore/inspector/front-end/AuditRules.js M Source/WebCore/inspector/front-end/CSSStyleModel.js Committed r82578
Note You need to log in before you can comment on or make changes to this bug.