Bug 59280

Summary: [Refactoring] NodeRenderParentDetector should be NodeRenderFactory
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 59157    
Attachments:
Description Flags
Patch dglazkov: review+

Hajime Morrita
Reported 2011-04-23 12:39:52 PDT
NodeRenderParentDetector is now in Node.cpp but it should have its own cpp/h.
Attachments
Patch (7.00 KB, patch)
2011-04-23 15:35 PDT, Hajime Morrita 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2011-04-23 15:18:02 PDT
The role of this class is not clear yet. So i postpone to make a separate file and do a refactoring first.
Hajime Morrita
Comment 2 2011-04-23 15:35:32 PDT
Created attachment 90861 [details] Patch
Dimitri Glazkov (Google)
Comment 3 2011-04-23 16:38:54 PDT
Comment on attachment 90861 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90861&action=review ok with nits. > Source/WebCore/ChangeLog:5 > + [Refactoring] NodeRenderParentDetector should have its own file Need to change the title here too. > Source/WebCore/dom/Node.cpp:1614 > + return NodeRendererFactory(const_cast<Node*>(this)).parentNodeForRenderingAndStyle(); Should we just remove the const modifier on the calling method?
Hajime Morrita
Comment 4 2011-04-23 17:52:03 PDT
Committed r84747: <http://trac.webkit.org/changeset/84747>
Note You need to log in before you can comment on or make changes to this bug.