Bug 72506

Summary: [WebKit2] Web Inspector: window.open should work inside inspector front-end
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web InspectorAssignee: Yury Semikhatsky <yurys>
Status: RESOLVED WONTFIX    
Severity: Normal CC: andersca, apavlov, burg, bweinstein, graouts, joepeck, keishi, loislo, pfeldman, pmuellr, rik, sam, timothy, webkit-bug-importer, yurys
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 73069    
Attachments:
Description Flags
Patch
none
Patch timothy: review-

Yury Semikhatsky
Reported 2011-11-16 07:58:51 PST
window.open needs to be implemented for inspector front-end pages in order to open inspector windows for dedicated workers.
Attachments
Patch (4.04 KB, patch)
2011-11-16 08:06 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (4.38 KB, patch)
2011-11-17 08:39 PST, Yury Semikhatsky 		timothy: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2011-11-16 08:06:53 PST
Created attachment 115380 [details] Patch
Yury Semikhatsky
Comment 2 2011-11-16 08:09:53 PST
(In reply to comment #1) > Created an attachment (id=115380) [details] > Patch I'm not sure if it is correct approach to initialize one WebUIClient from another or should we only copy createNewPage* mehods and version on the corresponding WKPageUIClient instances.
Yury Semikhatsky
Comment 3 2011-11-16 22:49:37 PST
Timothy or Joseph, can you take a look at this change?
Timothy Hatcher
Comment 4 2011-11-17 07:33:33 PST
What do you mean by "open inspector windows for dedicated workers"? Workers as in the Workers API or just helper windows?
Timothy Hatcher
Comment 5 2011-11-17 07:49:09 PST
Comment on attachment 115380 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115380&action=review > Source/WebKit2/ChangeLog:6 > + Inspector front-end page now has the same WebUIClient as inspected page. Please describe the reason/motivation for these changes.
Yury Semikhatsky
Comment 6 2011-11-17 08:16:33 PST
(In reply to comment #4) > What do you mean by "open inspector windows for dedicated workers"? Workers as in the Workers API or just helper windows? I meant that we need this to inspect dedicated workers running inside inspected page. Page inspector lists all running workers and should allow opening separate inspector front-end for each of them. To open such front-end from the page's inspector front-end we need window.open() to work there.
Yury Semikhatsky
Comment 7 2011-11-17 08:39:52 PST
Created attachment 115600 [details] Patch
Timothy Hatcher
Comment 8 2011-11-19 12:53:16 PST
I'd like Sam or Anders to look at this.
Timothy Hatcher
Comment 9 2011-11-29 12:55:16 PST
Comment on attachment 115600 [details] Patch Sorry for not giving this much thought earlier. But now that I understand what is going on here, this should not land. Hooking up the inspected page's UI client to a non-Safari created WKView is a bad idea (breaking some assumptions that Safari has the WKPage that gets passed ot its client). Also windows opened with window.open will be Safari windows, not WebKit controlled windows. You will have Find in Page and other browser features in the window.open windows that don't (and shouldn't exist) in the Web Inspector. We should implement a UIClient in WebKit2 that handles window.open and makes a WebKit owned window/WKView. This patch is all about WebKit2, but we should implement this in WebKit also, which still has the Web Inspector and is used by clients other than Safari.
Brian Burg
Comment 10 2014-08-03 19:21:57 PDT
I don't think we have any need for opening extra inspector windows, as workers are not inspectable right now. In any case, the WK2 bits will need to be rewritten.
Radar WebKit Bug Importer
Comment 11 2014-08-03 19:22:04 PDT
<rdar://problem/17898462>
Timothy Hatcher
Comment 12 2014-08-04 07:42:31 PDT
YEah and our ideal worker debugging experience is not a separate window.
Note You need to log in before you can comment on or make changes to this bug.