Bug 79672

Summary: Performance: stop recomputing SVG path data twice during layout
Product: WebKit Reporter: Philip Rogers <pdr>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: rhodovan.u-szeged, schenney, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Stop recomputing SVG path data twice during layout none

Philip Rogers
Reported 2012-02-27 07:28:58 PST
We currently recompute SVG path data twice during layout, but we only need to do this once. This is especially bad in the case of circles and ellipses, where each call to createShape() ends up creating 4 expensive cubics. Patch forthcoming!
Attachments
Stop recomputing SVG path data twice during layout (1.65 KB, patch)
2012-02-27 07:31 PST, Philip Rogers 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philip Rogers
Comment 1 2012-02-27 07:31:07 PST
Created attachment 129035 [details] Stop recomputing SVG path data twice during layout
Nikolas Zimmermann
Comment 2 2012-02-27 08:54:05 PST
Comment on attachment 129035 [details] Stop recomputing SVG path data twice during layout Nice catch, r=me.
WebKit Review Bot
Comment 3 2012-02-27 09:56:09 PST
The commit-queue encountered the following flaky tests while processing attachment 129035 [details]: css3/filters/effect-invert-hw.html bug 79639 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 4 2012-02-27 09:58:09 PST
Comment on attachment 129035 [details] Stop recomputing SVG path data twice during layout Clearing flags on attachment: 129035 Committed r109003: <http://trac.webkit.org/changeset/109003>
WebKit Review Bot
Comment 5 2012-02-27 09:58:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.