Bug 90530

Summary: REGRESSION(r121792): inspector/extensions/extensions-resources.html fails
Product: WebKit Reporter: Zoltan Arvai <zarvai>
Component: Tools / TestsAssignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: caseq, ossy, pfeldman, vsevik
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79666, 89868    
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Zoltan Arvai
Reported 2012-07-04 01:48:19 PDT
Modified test fails after r121792 on Qt and Lion. --- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-resources-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-resources-actual.txt @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: line 11: don't panic! +FAIL: Timed out waiting for notifyDone to be called Tests resource-related methods of WebInspector extension API @@ -60,27 +60,4 @@ content committed for resource .../audits-style1.css (type: stylesheet), new content: div.test { width: 220px; height: 42px; } Revision content: div.test { width: 220px; height: 42px; } RUNNING TEST: extension_testOnResourceAdded -resource added: -{ - 0 : { - url : data:application/javascript... - type : "script" - getContent : <function> - setContent : <function> - } -} -RUNNING TEST: extension_testOpenResourceHandler -handleOpenResource() invoked [this should only appear once!]: -{ - 0 : { - url : .../extensions-resources.html - type : "document" - getContent : <function> - setContent : <function> - } - 1 : 11 -} -RUNNING TEST: extension_testSetResourceContent -div.test width after stylesheet edited (should be 126): 126 -All tests done.
Attachments
Patch (5.64 KB, patch)
2012-07-04 03:02 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (5.74 KB, patch)
2012-07-04 03:18 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Arvai
Comment 1 2012-07-04 02:09:52 PDT
Skipped on Qt in http://trac.webkit.org/changeset/121839 . Please unskip it with the proper fix.
Vsevolod Vlasov
Comment 2 2012-07-04 03:02:11 PDT
Created attachment 150750 [details] Patch
Andrey Kosyakov
Comment 3 2012-07-04 03:14:01 PDT
Comment on attachment 150750 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150750&action=review > LayoutTests/http/tests/inspector/debugger-test.js:56 > + InspectorTest.finishDebuggerTest(completeTest); > + > + function completeTest() > + { > InspectorTest.completeTest(); > } Just InspectorTest.finishDebuggerTest(InspectorTest.completeTest.bind(this))? > LayoutTests/inspector/extensions/extensions-resources-expected.txt:83 > - 1 : 11 > + 1 : 12 nit: you could as well have moved logMessage() to a separate <script> on the top of the file, so that we stop re-baselining the test upon adding new scripts. > LayoutTests/inspector/extensions/extensions-resources.html:173 > + return; indent
Vsevolod Vlasov
Comment 4 2012-07-04 03:18:43 PDT
Created attachment 150758 [details] Patch
Vsevolod Vlasov
Comment 5 2012-07-04 05:33:12 PDT
Committed r121842: <http://trac.webkit.org/changeset/121842>
Note You need to log in before you can comment on or make changes to this bug.