Bug 91879

Summary: [CSS Exclusions] Test incremental layout
Product: WebKit Reporter: Bear Travis <betravis>
Component: CSSAssignee: Bear Travis <betravis>
Status: RESOLVED FIXED    
Severity: Normal CC: donggwan.kim, jchaffraix, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 89259    
Bug Blocks: 89256    
Attachments:
Description Flags
Adding tests
jchaffraix: review+
Updated patch none

Bear Travis
Reported 2012-07-20 10:20:24 PDT
Split from bug 89259, per Alex's comments: Can you also make a test where the text is changed dynamically? There's no code dealing with incremental layouts. I would add a bug for that and keep it in a different patch.
Attachments
Adding tests (5.15 KB, patch)
2012-09-10 16:01 PDT, Bear Travis 		jchaffraix: review+
DetailsFormatted DiffDiff
Updated patch (5.17 KB, patch)
2012-09-11 17:27 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bear Travis
Comment 1 2012-09-10 16:01:02 PDT
Created attachment 163240 [details] Adding tests Testing adding text and a shape-inside via javascript
Julien Chaffraix
Comment 2 2012-09-11 16:49:23 PDT
Comment on attachment 163240 [details] Adding tests View in context: https://bugs.webkit.org/attachment.cgi?id=163240&action=review Nit: Maybe we should also test changing from one -webkit-shape-inside to another one? > LayoutTests/fast/exclusions/shape-inside/shape-inside-dynamic-shape-expected.html:24 > + This text should be contained by the blue square. Don't forget to add a description of what you test. For example, here that dynamically setting -webkit-shape-inside properly relayout.
Bear Travis
Comment 3 2012-09-11 17:27:42 PDT
Created attachment 163487 [details] Updated patch Added descriptions to the bug, and filed bug 96451 to test changing between shapes once we have multiple shape-inside types working.
WebKit Review Bot
Comment 4 2012-09-12 10:32:14 PDT
Comment on attachment 163487 [details] Updated patch Clearing flags on attachment: 163487 Committed r128336: <http://trac.webkit.org/changeset/128336>
WebKit Review Bot
Comment 5 2012-09-12 10:32:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.