Bug 98212

Summary: [WK2] Support all attributes of GeolocationPosition
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: WebKit2Assignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, gyuyoung.kim, rakuco, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch sam: review+

Benjamin Poulain
Reported 2012-10-02 16:41:53 PDT
We only support the 3 basic attributes.
Attachments
Patch (56.78 KB, patch)
2012-10-02 16:59 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (56.76 KB, patch)
2012-10-02 18:35 PDT, Benjamin Poulain 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-10-02 16:59:01 PDT
Created attachment 166779 [details] Patch
WebKit Review Bot
Comment 2 2012-10-02 17:03:07 PDT
Attachment 166779 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 LayoutTests/platform/qt/TestExpectations:2739: Path does not exist. [test/expectations] [5] LayoutTests/platform/qt/TestExpectations:2740: Path does not exist. [test/expectations] [5] Total errors found: 2 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 3 2012-10-02 18:35:42 PDT
Created attachment 166795 [details] Patch
WebKit Review Bot
Comment 4 2012-10-02 18:38:02 PDT
Attachment 166795 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 LayoutTests/platform/qt/TestExpectations:2739: Path does not exist. [test/expectations] [5] LayoutTests/platform/qt/TestExpectations:2740: Path does not exist. [test/expectations] [5] Total errors found: 2 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 5 2012-10-03 15:23:24 PDT
Comment on attachment 166795 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166795&action=review > Source/WebKit2/Shared/WebGeolocationPosition.cpp:56 > + encoder->encode(CoreIPC::In(timestamp, latitude, longitude, accuracy, canProvideAltitude, altitude, canProvideAltitudeAccuracy, altitudeAccuracy, canProvideHeading, heading, canProvideSpeed, speed)); Instead of adding the overload of CoreIPC::In(), can you just call encoder->encode multiple times. That has become more idiomatic in our code. > Source/WebKit2/Shared/WebGeolocationPosition.cpp:61 > + return decoder->decode(CoreIPC::Out(data.timestamp, data.latitude, data.longitude, data.accuracy, data.canProvideAltitude, data.altitude, data.canProvideAltitudeAccuracy, data.altitudeAccuracy, data.canProvideHeading, data.heading, data.canProvideSpeed, data.speed)); Same here.
Benjamin Poulain
Comment 6 2012-10-03 15:40:32 PDT
(In reply to comment #5) > Instead of adding the overload of CoreIPC::In(), can you just call encoder->encode multiple times. That has become more idiomatic in our code. I know, I just find it a little silly to have to limit ourself to 10 args :)
Benjamin Poulain
Comment 7 2012-10-04 12:10:06 PDT
Committed r130416: <http://trac.webkit.org/changeset/130416>
Jessie Berlin
Comment 8 2013-04-17 14:39:00 PDT
*** Bug 94554 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.