Bug 99757

Summary: [EFL] Buildfix if Netscape plugin support is disabled
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kbalazs, lucas.de.marchi, mariusz.g, ostap73, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Laszlo Gombos
Reported 2012-10-18 14:07:38 PDT
"build-webkit --no-netscape-plugin-api --efl" does not build.
Attachments
proposed patch (2.21 KB, patch)
2012-10-18 14:18 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2012-10-18 14:18:07 PDT
Created attachment 169475 [details] proposed patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-10-18 14:34:21 PDT
If this one fixes the current build break (as in <http://build.webkit.org/builders/EFL Linux 32-bit Release (Build)/builds/8502/steps/compile-webkit/logs/stdio>), I'd go as far as just committing it as unreviewed build fix.
Viatcheslav Ostapenko
Comment 3 2012-10-18 15:09:31 PDT
(In reply to comment #2) > If this one fixes the current build break (as in <http://build.webkit.org/builders/EFL Linux 32-bit Release (Build)/builds/8502/steps/compile-webkit/logs/stdio>), I'd go as far as just committing it as unreviewed build fix. No, it fixes build if plugins are disabled. By default they are enabled.
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-10-18 15:34:39 PDT
(In reply to comment #3) > (In reply to comment #2) > > If this one fixes the current build break (as in <http://build.webkit.org/builders/EFL Linux 32-bit Release (Build)/builds/8502/steps/compile-webkit/logs/stdio>), I'd go as far as just committing it as unreviewed build fix. > > No, it fixes build if plugins are disabled. By default they are enabled. Does this fix https://bugs.webkit.org/show_bug.cgi?id=91844#c66 and its follow-up response then?
Viatcheslav Ostapenko
Comment 5 2012-10-18 15:37:44 PDT
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > If this one fixes the current build break (as in <http://build.webkit.org/builders/EFL Linux 32-bit Release (Build)/builds/8502/steps/compile-webkit/logs/stdio>), I'd go as far as just committing it as unreviewed build fix. > > > > No, it fixes build if plugins are disabled. By default they are enabled. > > Does this fix https://bugs.webkit.org/show_bug.cgi?id=91844#c66 and its follow-up response then? Yes, it should fix --no-netscape-plugin-api build.
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-10-18 16:11:08 PDT
(In reply to comment #5) > > Does this fix https://bugs.webkit.org/show_bug.cgi?id=91844#c66 and its follow-up response then? > > Yes, it should fix --no-netscape-plugin-api build. Right. If it addresses Mariusz's concerns in that bug report, I guess it should be fine. Once it lands, please comment on that bug so that everyone knows the issue has been fixed.
Gyuyoung Kim
Comment 7 2012-10-18 19:12:55 PDT
Comment on attachment 169475 [details] proposed patch It would be good if you say this is fixed on the Rafael's comment. :-)
WebKit Review Bot
Comment 8 2012-10-18 19:35:57 PDT
Comment on attachment 169475 [details] proposed patch Clearing flags on attachment: 169475 Committed r131843: <http://trac.webkit.org/changeset/131843>
WebKit Review Bot
Comment 9 2012-10-18 19:36:02 PDT
All reviewed patches have been landed. Closing bug.
Mariusz Grzegorczyk
Comment 10 2012-10-19 00:36:59 PDT
This is a part of bigger problem. See following bug: https://bugs.webkit.org/show_bug.cgi?id=98401
Note You need to log in before you can comment on or make changes to this bug.