RESOLVED FIXED145575
MediaSessions should keep track of their current state 
https://bugs.webkit.org/show_bug.cgi?id=145575
Summary MediaSessions should keep track of their current state
Matt Rajca
Reported 2015-06-02 15:18:48 PDT
Per the Media Session spec, each Media Session has a current state, which is 'Idle' at the time of construction.
Attachments
Patch (1.34 KB, patch)
2015-06-02 15:33 PDT, Matt Rajca 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-06-02 15:19:28 PDT
<rdar://problem/21210114>
Matt Rajca
Comment 2 2015-06-02 15:33:19 PDT
Created attachment 254113 [details] Patch
Conrad Shultz
Comment 3 2015-06-02 15:41:39 PDT
Comment on attachment 254113 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254113&action=review > Source/WebCore/Modules/mediasession/MediaSession.h:55 > + }; Will this state eventually be exposed publicly? If so, should this start out outside the private section?
Matt Rajca
Comment 4 2015-06-02 15:44:21 PDT
Comment on attachment 254113 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254113&action=review >> Source/WebCore/Modules/mediasession/MediaSession.h:55 >> + }; > > Will this state eventually be exposed publicly? If so, should this start out outside the private section? This state is not exposed in the MediaSession IDL "interface" file, so we should keep it private until we actually need to access it outside of the Media Session itself.
Alex Christensen
Comment 5 2015-06-02 16:03:19 PDT
Comment on attachment 254113 [details] Patch This is good, but I think it should be included with some changes that actually use it.
WebKit Commit Bot
Comment 6 2015-06-02 17:45:25 PDT
Comment on attachment 254113 [details] Patch Clearing flags on attachment: 254113 Committed r185136: <http://trac.webkit.org/changeset/185136>
WebKit Commit Bot
Comment 7 2015-06-02 17:45:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.