RESOLVED FIXED146355
Add support for 'Default' media session types 
https://bugs.webkit.org/show_bug.cgi?id=146355
Summary Add support for 'Default' media session types
Matt Rajca
Reported 2015-06-26 11:48:49 PDT
Media elements that do not specify a media session content kind should be assigned the top-level browsing context's media session.
Attachments
Patch (5.91 KB, patch)
2015-06-26 16:58 PDT, Matt Rajca 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-06-26 11:49:39 PDT
<rdar://problem/21569054>
Matt Rajca
Comment 2 2015-06-26 16:58:29 PDT
Created attachment 255676 [details] Patch
Darin Adler
Comment 3 2015-06-27 15:31:16 PDT
Comment on attachment 255676 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255676&action=review > Source/WebCore/Modules/mediasession/MediaSession.cpp:62 > + , m_kind(MediaSession::Kind::Default) Here in the MediaSession class, the name of this type is Kind, not MediaSession::Kind, so can leave off the MediaSession part. Seems that m_kind could default to this in the header, then we could omit it in this constructor. Syntax we would normally use in the class definition is: Kind m_kind { Kind::Default }; > Source/WebCore/Modules/mediasession/MediaSession.h:53 > + MediaSession(Document&); Probably should be: explicit MediaSession(Document&);
Matt Rajca
Comment 4 2015-06-28 22:21:45 PDT
(In reply to comment #3) > Comment on attachment 255676 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=255676&action=review > > > Source/WebCore/Modules/mediasession/MediaSession.cpp:62 > > + , m_kind(MediaSession::Kind::Default) > > Here in the MediaSession class, the name of this type is Kind, not > MediaSession::Kind, so can leave off the MediaSession part. > > Seems that m_kind could default to this in the header, then we could omit it > in this constructor. Syntax we would normally use in the class definition is: > > Kind m_kind { Kind::Default }; That's simpler. Changed. > > > Source/WebCore/Modules/mediasession/MediaSession.h:53 > > + MediaSession(Document&); > > Probably should be: > > explicit MediaSession(Document&); Yup, looks like we use `explicit` heavily throughout WebKit to avoid implicit conversions with single-argument constructors. Thanks!
Matt Rajca
Comment 5 2015-06-28 22:32:33 PDT
Committed r186064: <http://trac.webkit.org/changeset/186064>
Note You need to log in before you can comment on or make changes to this bug.